Fix report search for "pending approval of" #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 8eb6ac5 into 4adb2b1 - view on LGTM.com new alerts:
|
gjvoosten
requested review from
cemalettin-work,
midmarch,
VassilIordanov,
MehmetAli-Simsoft and
bssimsoft
gjvoosten
force-pushed
the
GH-3442-fix-pendingApproval
branch
from
a56dc76 to
6a6b1ee
Compare
Since this test is using a default pageSize of 10, it will succeed.
This is what's used for the Home tile of "Reports pending my approval". The test will fail now, since the code has not yet been fixed.
…ng approval of someone Since for reports searched by pendingApprovalOf we have to do some (difficult) post-processing, first query the database for all reports, then post-process them, and finally slice the requested page from the remaining results. Thus we get an accurate totalCount and correctly filled pages of results. It means we're retrieving more results rows than we actually need (and return), but since users don't normally have a huge amount of reports pending their approval, this is acceptable.
gjvoosten
force-pushed
the
GH-3442-fix-pendingApproval
branch
from
6a6b1ee to
1054bb5
Compare
MehmetAli-Simsoft
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the Home tile for "Reports pending my approval", and report search results for "pending approval of", show the correct number of results.
Closes #3442
User changes
Super User changes
Admin changes
System admin changes
Checklist
repo#issue: Titletitle format and these 7 rules