Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Insight showing the positions that have pending assessments #3415

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

gjvoosten
Copy link
Collaborator

The Position search has an additional filter Has Pending Assessments: Yes (which implicitly means also searching for active, filled, advisor positions). An Insight is added that takes the results of this search and presents them in a clear view.

Closes #2213

User changes

  • Position search has an additional filter Has Pending Assessments: Yes

Super User changes

  • Super Users have access to the Insights in the left-hand navigation menu (due to performance reasons this was disabled some time ago; it is re-enabled now).
  • A new Insight Pending Assessments by Position is available that shows advisors in your organization hierarchy with pending assessments (for principals or tasks).

Admin changes

  • A new Insight Pending Assessments by Position is available that shows advisors across all organizations with pending assessments (for principals or tasks).

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten force-pushed the GH-2213-pending-assessments-insight branch from d0bc75b to 077817c Compare February 1, 2021 10:33
@gjvoosten gjvoosten force-pushed the GH-2213-pending-assessments-insight branch from 077817c to 9f03b8f Compare February 9, 2021 12:56
@gjvoosten gjvoosten marked this pull request as ready for review February 9, 2021 13:43
@cemalettin-work
Copy link
Contributor

Is having the 'has pending assessments' filter available to everyone a good idea / desired? Maybe subordinates shouldn't see their superiors having a pending task etc. Just a thought.

@gjvoosten
Copy link
Collaborator Author

Is having the 'has pending assessments' filter available to everyone a good idea / desired? Maybe subordinates shouldn't see their superiors having a pending task etc. Just a thought.

I'm agnostic on this. Just be aware that any user can already find this out by looking at the individual tasks (it's just more work having to go through them one by one). So the information itself is readily available to any user, this just makes finding it more convenient.

@gjvoosten gjvoosten force-pushed the GH-2213-pending-assessments-insight branch from 9f03b8f to d1d5f5c Compare February 11, 2021 08:58
@gjvoosten gjvoosten force-pushed the GH-2213-pending-assessments-insight branch 2 times, most recently from 64fe6b4 to 042b1aa Compare February 18, 2021 07:48
@gjvoosten gjvoosten force-pushed the GH-2213-pending-assessments-insight branch from 042b1aa to 22754da Compare February 24, 2021 07:44
…ents

Refactor the PendingAssessmentsNotificationWorker for this; we want to re-use most of the code.
Add an asynchronous Position search so we can use the refactored PendingAssessmentsHelper.
@gjvoosten gjvoosten force-pushed the GH-2213-pending-assessments-insight branch from 22754da to af12a0d Compare February 25, 2021 07:42
@VassilIordanov VassilIordanov merged commit ce9395f into candidate Mar 2, 2021
@VassilIordanov VassilIordanov deleted the GH-2213-pending-assessments-insight branch March 2, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaders want to know how they can verify their advisors have completed their monthly principal assessment
3 participants