-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency jsonpath-plus to v5 #3398
Conversation
a9a6ac1
to
2a34e0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the JSONPATH function takes very long after the update, parsing is very slow which fails the tests. Can be a bug in the new version
c6ea081
to
7bcb5fd
Compare
Actually, it appears the semantics of some of the path lookups have changed with v5, e.g. this:
now appears to do a recursive lookup underneath
speeds this up significantly (by a factor of 10), although it's still a lot slower than with v4 (v4: 3 ms or less, v5: more than 100 ms). |
The slowness is only apparent in the browser, it seems. I tested both v4 and v5 with https://github.com/andykais/json-querying-performance-testing and saw no significant slowdown between the two (but this is running in NodeJS, not the browser). |
In the browser demo of jsonpath-plus, there is also no speed difference between v4 and v5. If I revert to ANET 2.1.39 (just before the Webpack 5 upgrade) and update jsonpath-plus, the slowness is gone. So the most likely suspect is our Webpack 5 config. |
7bcb5fd
to
4eeeb45
Compare
4eeeb45
to
c56c68b
Compare
ad8aaf7
to
0799027
Compare
Turns out it's due the the package exports of jsonpath-plus; see JSONPath-Plus/JSONPath#145 and JSONPath-Plus/JSONPath#146 |
Don't recurse down the tree.
b1f4afe
to
a54032b
Compare
…browser Brings performance back to normal speed, so test should pass again.
This PR contains the following updates:
4.0.0
->5.0.2
Release Notes
s3u/JSONPath
v5.0.2
Compare Source
v5.0.1
Compare Source
v5.0.0
Compare Source
type: 'commonjs'
andexports: {import, require}
(with
node-import-test
npm script to demo)dist/index-browser-umd.js
ordist/index-browser-es.js
)(for Node,
main
andmodule
point to new Node-specific dist)browser
for browser bundling;allowing static analysis environments, doesn't have however
conditional code to require
vm
); for ESM browser bundling,now must check
browser
in Rollup Node resolver plugin;see README
.match
) example on value (@jeffreypriebe).match
) example on propertydist
field to avoid extra config reportingrollup-plugin-babel
to@rollup/plugin-babel
(and make
babelHelpers
explicit)Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.