Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend custom fields to Position, Organization, Location #3377

Conversation

cemalettin-work
Copy link
Contributor

@cemalettin-work cemalettin-work commented Dec 23, 2020

Position, Organization and Location will now have custom fields defined. System admins can update anet-dictionary.yml file to choose what kind of fields they would like to add to these types.

Added customFields columns to positions, organizations and locations table. The development anet-dictionary.yml file has these three new custom fields same as person.customFields, system admins should update these according to their requirements.

Closes #3367

User changes

  • Users will see additional fields from custom fields in these pages/forms.

Super User changes

  • Super users will see additional fields ( custom fields) that needs to be filled when creating Position, Location, Organization

Admin (System admin) changes

  • dictionary.fields.position.customFields, dictionary.fields.organization.customFields, dictionary.fields.location.customFields can be filled according to requirements.

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@cemalettin-work cemalettin-work force-pushed the GH-3367-extend-custom-fields-to-other-anet-object-types branch from 53b8793 to 0254b97 Compare December 28, 2020 06:25
@cemalettin-work cemalettin-work marked this pull request as ready for review January 4, 2021 09:23
@cemalettin-work cemalettin-work force-pushed the GH-3367-extend-custom-fields-to-other-anet-object-types branch from 0254b97 to d7b3a0f Compare January 4, 2021 10:03
@cemalettin-work
Copy link
Contributor Author

I can save the customFields to the database, but I can't seem to query customFields for what is saved, could use some help 😄

@VassilIordanov VassilIordanov merged commit d53386e into candidate Jan 7, 2021
@VassilIordanov VassilIordanov deleted the GH-3367-extend-custom-fields-to-other-anet-object-types branch January 7, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend customFields to additional types
3 participants