Add tests for a different anet dictionary which doesn't have custom fields #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add no custom fields dictionary version to test Also add todo comment on github workflow config
cemalettin-work
force-pushed
the
GH-3368-add-tests-for-different-dictionaries
branch
from
7f3ada3 to
53a269a
Compare
cemalettin-work
force-pushed
the
GH-3368-add-tests-for-different-dictionaries
branch
2 times, most recently
from
bb6f7a1 to
e6b1f10
Compare
cemalettin-work
requested review from
gjvoosten,
VassilIordanov,
MehmetAli-Simsoft and
ysf-simsoft
Do not assume custom fields exist.
gjvoosten
force-pushed
the
GH-3368-add-tests-for-different-dictionaries
branch
from
e6b1f10 to
017f3af
Compare
gjvoosten
approved these changes
Dec 21, 2020
14 tasks
This was referenced Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test dictionary which doesn't contain custom fields as they are optional. ANET should work fine without custom fields. Changed the way webdriverio tests are grouped so that we can use the test files with different anet dictionaries. Tests that don't depend on custom fields are grouped as base test specs, others are separated.
Also additional github jobs added for testing these in parallel
Also fixes Person creation page error.
Closes #3368
User changes
Super User changes
Admin changes
System admin changes
Checklist
repo#issue: Titletitle format and these 7 rules