Fix position form organization being required #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemalettin-work
force-pushed
the
fix-position-form-org-required
branch
4 times, most recently
from
ab38dd7 to
9e1e0f3
Compare
cemalettin-work
force-pushed
the
fix-position-form-org-required
branch
5 times, most recently
from
c5c843b to
309d78e
Compare
cemalettin-work
requested review from
MehmetAli-Simsoft,
gjvoosten and
ysf-simsoft
gjvoosten
requested changes
Dec 21, 2020
…e request As otherwise we would never get to the required organization exception
It is probably a Yup or Formik bug, this is a workaround
Add create position test cases for required fields
cemalettin-work
force-pushed
the
fix-position-form-org-required
branch
from
309d78e to
8a813d8
Compare
gjvoosten
requested changes
Dec 21, 2020
…e changes Also make required fields' message consistent and concise State update should be done with setFieldValue not by mutating 'values'
cemalettin-work
force-pushed
the
fix-position-form-org-required
branch
from
8a813d8 to
14a503e
Compare
gjvoosten
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, position form does not show to the users (admins/ super-users) that organization field is required.
So when an admin or a super-user tries to submit a position with only position name ( as it is the only one shown as required), server returns a response: "You do not have permissions to do this". In reality, the user has permission but organization being missing would result into a fail in
isSuperUserForOrg. We should return something along the lines of "organization is required" response.Also,
editPosition.specs.jsfile and tests are not editing any position but creating, which is confusing. It goes to the create position page, so i named the tests/pages accordingly. Also added some test cases for required fields.Also fixes:
User changes
Super User changes
Admin changes
System admin changes
Checklist
repo#issue: Titletitle format and these 7 rules