-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance person view and make ANET more responsive #3330
Merged
midmarch
merged 44 commits into
candidate
from
GH-3235-enhance-person-view-and-anet-responsive
Mar 30, 2021
Merged
Enhance person view and make ANET more responsive #3330
midmarch
merged 44 commits into
candidate
from
GH-3235-enhance-person-view-and-anet-responsive
Mar 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
cemalettin-work
force-pushed
the
GH-3235-enhance-person-view-and-anet-responsive
branch
from
December 7, 2020 06:24
37ce9bf
to
f42764b
Compare
cemalettin-work
requested review from
gjvoosten,
ysf-simsoft,
maradragan and
VassilIordanov
December 7, 2020 07:13
cemalettin-work
force-pushed
the
GH-3235-enhance-person-view-and-anet-responsive
branch
from
December 8, 2020 07:14
7a922bb
to
aa4505a
Compare
cemalettin-work
force-pushed
the
GH-3235-enhance-person-view-and-anet-responsive
branch
from
December 10, 2020 12:17
6a92426
to
49f2b35
Compare
cemalettin-work
force-pushed
the
GH-3235-enhance-person-view-and-anet-responsive
branch
2 times, most recently
from
December 21, 2020 04:59
b067ad2
to
06e3384
Compare
cemalettin-work
force-pushed
the
GH-3235-enhance-person-view-and-anet-responsive
branch
from
December 22, 2020 06:48
06e3384
to
fcc3bf9
Compare
cemalettin-work
force-pushed
the
GH-3235-enhance-person-view-and-anet-responsive
branch
3 times, most recently
from
December 28, 2020 06:17
9260467
to
e0bfb30
Compare
cemalettin-work
force-pushed
the
GH-3235-enhance-person-view-and-anet-responsive
branch
3 times, most recently
from
January 11, 2021 09:13
0833023
to
40100d7
Compare
ysf-simsoft
suggested changes
Jan 13, 2021
cemalettin-work
force-pushed
the
GH-3235-enhance-person-view-and-anet-responsive
branch
2 times, most recently
from
January 14, 2021 12:33
0ff6daf
to
ed7ca54
Compare
cemalettin-work
force-pushed
the
GH-3235-enhance-person-view-and-anet-responsive
branch
2 times, most recently
from
January 18, 2021 11:45
4eebbf9
to
a141360
Compare
Remove guided tour on on small screens Responsive position tables Make notes larger when opened
Make report tables responsive so it can be scrollable on small screens
And do another filter for components existing Which normally shouldn't filter anything but better than crash
Fix kanban board scroll missing Make daily rollup date range more responsive
Also refactor the logic into functions Also move the constants/functions away from Formik comp to upper level
Position action buttons are inlined with tooltips Some of the warning messages when person had no position are removed
Add new dictionary field for person Also fix tests that would break
Also add comments
Not every person page view, unnecessary
Also refactor for requested changes
Also fix minor typo in test dictionary
targetClassName was removed, className is the correct one to add class to target
cemalettin-work
force-pushed
the
GH-3235-enhance-person-view-and-anet-responsive
branch
from
March 10, 2021 13:25
a4a4148
to
d8a039f
Compare
gjvoosten
approved these changes
Mar 29, 2021
midmarch
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Person Page made two column layout and the fields order can be changed, and some parts of the ANET made more responsive.
Closes #3235
Closes #3293
Closes #3281
Closes #1916
User changes
Super User changes
Admin changes
System admin changes
anet.yml or anet-dictionary.yml needs change
There are 2 additional fields for
fields.person
and 2 additional fields forfields.principal.person
andfields.advisor.person
in the anet-dictionary.yml:New fields for person (
field: label_to_show_in_UI
):New fields for
advisor.person
andprincipal.person
:Admins need to select and order which person fields (custom fields included) and in what order they will be shown on the Person page by providing those fields under
advisor.person.fields.showPageOrderedFields
andprincipal.person.fields.showPageOrderedFields
.Example usage, admins need to adjust the number of fields (N) so that two columns are somewhat balanced (Some fields can have a lot of data in them e.g previous positions can be long):
The result for advisor pages would be:
db needs migration
documentation has changed
graphql schema has changed
Checklist
repo#issue: Title
title format and these 7 rules