Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance person view and make ANET more responsive #3330

Merged
merged 44 commits into from
Mar 30, 2021

Conversation

cemalettin-work
Copy link
Contributor

@cemalettin-work cemalettin-work commented Dec 2, 2020

Person Page made two column layout and the fields order can be changed, and some parts of the ANET made more responsive.

Closes #3235
Closes #3293
Closes #3281
Closes #1916

User changes

  • Users will see a more compact Person page and will be able to use ANET more easily on small width devices.

Super User changes

  • The buttons and fields on a person page has been changed. So edit position and change assigned position buttons are in the person information block.

Admin changes

  • The buttons and fields on a person page has been changed. So edit position and change assigned position buttons are in the person information block.

System admin changes

  • anet.yml or anet-dictionary.yml needs change

    • There are 2 additional fields for fields.person and 2 additional fields for fields.principal.person and fields.advisor.person in the anet-dictionary.yml:

      • New fields for person (field: label_to_show_in_UI):

          person:
            position: Current Position
            prevPositions: Previous Positions
        
      • New fields for advisor.person and principal.person:

          advisor:
            person:
              # N is the number of fields after Avatar in the left column for advisors
              numberOfFieldsInLeftColumn: N
              showPageOrderedFields:
        
          principal:
            person:
              # N is the number of fields after Avatar in the left column for principals
              numberOfFieldsInLeftColumn: N
              showPageOrderedFields:
        
    • Admins need to select and order which person fields (custom fields included) and in what order they will be shown on the Person page by providing those fields under advisor.person.fields.showPageOrderedFields and principal.person.fields.showPageOrderedFields .

    Example usage, admins need to adjust the number of fields (N) so that two columns are somewhat balanced (Some fields can have a lot of data in them e.g previous positions can be long):

      advisor:
        person:
          # number of fields after Avatar in the left column for advisors
          numberOfFieldsInLeftColumn: N
          showPageOrderedFields:
            - position
            - prevPositions
            - emailAddress
            - multipleButtons
            ...
    
    

    The result for advisor pages would be:

    first column second column
    «Avatar» «N + 1»
    «position» «N + 2»
    «prevPositions» «N + 3»
    «emailAddress» «N + 4»
    «multipleButtons» «N + 5»
    «…» «N + …»
    «N» «N + …»
  • db needs migration

  • documentation has changed

  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@cemalettin-work cemalettin-work force-pushed the GH-3235-enhance-person-view-and-anet-responsive branch from 37ce9bf to f42764b Compare December 7, 2020 06:24
@cemalettin-work cemalettin-work marked this pull request as ready for review December 7, 2020 07:13
@cemalettin-work cemalettin-work force-pushed the GH-3235-enhance-person-view-and-anet-responsive branch from 7a922bb to aa4505a Compare December 8, 2020 07:14
@cemalettin-work cemalettin-work marked this pull request as draft December 8, 2020 12:13
@cemalettin-work cemalettin-work force-pushed the GH-3235-enhance-person-view-and-anet-responsive branch from 6a92426 to 49f2b35 Compare December 10, 2020 12:17
@cemalettin-work cemalettin-work marked this pull request as ready for review December 14, 2020 15:33
@cemalettin-work cemalettin-work force-pushed the GH-3235-enhance-person-view-and-anet-responsive branch 2 times, most recently from b067ad2 to 06e3384 Compare December 21, 2020 04:59
@cemalettin-work cemalettin-work force-pushed the GH-3235-enhance-person-view-and-anet-responsive branch from 06e3384 to fcc3bf9 Compare December 22, 2020 06:48
@cemalettin-work cemalettin-work linked an issue Dec 22, 2020 that may be closed by this pull request
@cemalettin-work cemalettin-work force-pushed the GH-3235-enhance-person-view-and-anet-responsive branch 3 times, most recently from 9260467 to e0bfb30 Compare December 28, 2020 06:17
@cemalettin-work cemalettin-work force-pushed the GH-3235-enhance-person-view-and-anet-responsive branch 3 times, most recently from 0833023 to 40100d7 Compare January 11, 2021 09:13
client/src/components/AdvancedSearch.js Outdated Show resolved Hide resolved
client/src/components/AdvancedSearch.js Outdated Show resolved Hide resolved
client/src/index.css Show resolved Hide resolved
client/src/index.css Outdated Show resolved Hide resolved
client/src/index.css Outdated Show resolved Hide resolved
client/src/components/SearchBar.js Outdated Show resolved Hide resolved
client/src/periodUtils.js Outdated Show resolved Hide resolved
client/src/components/Kanban.js Outdated Show resolved Hide resolved
anet-dictionary.yml Outdated Show resolved Hide resolved
src/main/resources/anet-schema.yml Outdated Show resolved Hide resolved
@cemalettin-work cemalettin-work force-pushed the GH-3235-enhance-person-view-and-anet-responsive branch 2 times, most recently from 0ff6daf to ed7ca54 Compare January 14, 2021 12:33
@cemalettin-work cemalettin-work force-pushed the GH-3235-enhance-person-view-and-anet-responsive branch 2 times, most recently from 4eebbf9 to a141360 Compare January 18, 2021 11:45
Remove guided tour on on small screens

Responsive position tables

Make notes larger when opened
Make report tables responsive so it can be scrollable on small screens
And do another filter for components existing

Which normally shouldn't filter anything but better than crash
Fix kanban board scroll missing

Make daily rollup date range more responsive
Also refactor the logic into functions

Also move the constants/functions away from Formik comp to upper level
Position action buttons are inlined with tooltips

Some of the warning messages when person had no position are removed
Add new dictionary field for person

Also fix tests that would break
Not every person page view, unnecessary
Also refactor for requested changes
targetClassName was removed, className is the correct one to add class to target
@cemalettin-work cemalettin-work force-pushed the GH-3235-enhance-person-view-and-anet-responsive branch from a4a4148 to d8a039f Compare March 10, 2021 13:25
@midmarch midmarch self-requested a review March 30, 2021 12:52
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@midmarch midmarch merged commit 7bf0253 into candidate Mar 30, 2021
@midmarch midmarch deleted the GH-3235-enhance-person-view-and-anet-responsive branch March 30, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants