Fix ReportCollection undefined widgetIds as no mapId supplied #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemalettin-work
requested review from
gjvoosten,
ysf-simsoft and
VassilIordanov
Make mapId required for ReportMap
cemalettin-work
force-pushed
the
fix-ReportMapWidget-missing-widgetId-prop
branch
from
0ea2846 to
77a0a1f
Compare
gjvoosten
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ReportsMapWidget's widgetId is required now, we need to pass map ids from higher level comps.
continuation from #3292
System admin changes
Checklist
repo#issue: Titletitle format and these 7 rules