Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'No assessments' message when there are assessments #3285

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

cemalettin-work
Copy link
Contributor

@cemalettin-work cemalettin-work commented Nov 9, 2020

This pull request solves the issue of showing "No assessments" message in the assessments' table when there are assessments to show. Assessments are divided into two groups when dealing with user feedback. "Engagement Assessments" and "Periodic Assessments".

The reason for the previous behavior was that both of these assessments are evaluated separately but only engagement assessments returned a user feedback. Now both return a user feedback.

Note: If there is no config for "Engagement Assessments" or "Periodic Assessments", we don't show "No engagement/periodic assessments" message, as that task/person isn't even configured for such assessments.

User changes

  • Users will see a more detailed feedback on assessments table

Super User changes

Admin changes

System admin changes

  • anet.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@cemalettin-work
Copy link
Contributor Author

We can also show "No engagement assessments" or "No periodic assessments" even if that task/person isn't configured to show those. I am open to suggestions.

Divide the assessments into two groups when dealing with user feedback
@cemalettin-work cemalettin-work changed the title Fix 'No assessments' message error when there are assessments Fix 'No assessments' message when there are assessments Nov 16, 2020
@VassilIordanov VassilIordanov merged commit 57745f2 into candidate Nov 16, 2020
@VassilIordanov VassilIordanov deleted the fix-assessments-no-msg branch November 16, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants