Add a biweekly period implementation #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemalettin-work
commented
Nov 4, 2020
cemalettin-work
commented
Nov 4, 2020
cemalettin-work
force-pushed
the
GH-3068-implement-biweekly-assessment-period
branch
2 times, most recently
from
272aa63 to
ed9e4c6
Compare
maradragan
previously requested changes
Nov 9, 2020
cemalettin-work
force-pushed
the
GH-3068-implement-biweekly-assessment-period
branch
2 times, most recently
from
ec5af4f to
f38390b
Compare
cemalettin-work
force-pushed
the
GH-3068-implement-biweekly-assessment-period
branch
from
f38390b to
2f7d2d1
Compare
Add a choice of monday to the dictionary
Also revert isoWeek changes to weekly period, that might break old records
cemalettin-work
force-pushed
the
GH-3068-implement-biweekly-assessment-period
branch
from
2f7d2d1 to
e5869a6
Compare
VassilIordanov
approved these changes
Nov 16, 2020
VassilIordanov
deleted the
GH-3068-implement-biweekly-assessment-period
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have a broken biweekly period implementation for the task assessments' period. Now we have a biweely period which is basically the other Monday calculation from a specific date(chose "2021-01-04", 1st monday of 2021). Every monday that has even number of weeks apart from this date can be a biweekly period start.
Release notes
Closes #3068
User changes
Super User changes
Admin changes
System admin changes
Checklist
repo#issue: Titletitle format and these 7 rules