Fix semiannually and semimonthly period calculations

[cemalettin-work]

"semiannualy" and "semimonthly" periods were calculated incorrectly, this pr fixes those.
For "semiannualy", previous code would produce an incorrect period if you are at 2nd or 4th quarters currently:

  [RECURRENCE_TYPE.SEMIANNUALY]: (date, offset) => ({
    start: date
      .clone()
      .subtract(2 * offset, "quarters")
      .startOf("quarter"),
    end: date
      .clone()
      .subtract(2 * offset, "quarters")
      .endOf("quarter")
  }),

Example input: date = 30 October ( It shouldn't start from Octobers or Aprils, only 1 Jan or 1 July)

For "semimonthly", it is also incorrect, same input date, it misses first half of the months completely:

Fixed versions' behaviour:

• Semimonthly => (1st - 14th) -> (15th - end of Month)
• Semiannualy => (1 Jan - 30 June ) -> ( 1 July - 31 December)

User changes

• Users now can see correct periods when there are "semiannualy" and "semimonthly" assessment periods

Super User changes

Admin changes

System admin changes

• anet.yml or anet-dictionary.yml needs change
• db needs migration
• documentation has changed
• graphql schema has changed

Checklist

• Described the user behavior in PR body
• Referenced/updated all related issues
• commits follow a repo#issue: Title title format and these 7 rules
• commits have a clean history, otherwise PR may be squash-merged
• Added and/or updated unit tests
• Added and/or updated e2e tests
• Added and/or updated data migrations
• Updated documentation
• Resolved all build errors and warnings
• Opened debt issues for anything not resolved here

[VassilIordanov]

Please follow template for PRs and in it describe what is wrong with the current behavior and what the proposed new behavior is

[cemalettin-work]

I will write a couple of unit tests for semimonthly and semiannually, as they are the most complicated ones.

stale

resolved

[VassilIordanov]

Obviously anet.yml doesn't need change, but anet-dictionary.yml does (we need to update the PR template)