Fix getting responsibleTasks #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes part of commit 5c8df12, which would always get the responsibleTasks for the current user doing the request, instead of those belonging to the Person object. Move responsibleTasks to Position, as that is the proper place for it, and reflect this change in the JavaScript code requesting them.
gjvoosten
requested review from
VassilIordanov,
maradragan,
cemalettin-work and
a team
Add it to Position object in case we use it
cemalettin-work
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of commit 5c8df12, which would always get the responsibleTasks for the current user doing the request, instead of those belonging to the Person object.
Move responsibleTasks to Position, as that is the proper place for it, and reflect this change in the JavaScript code requesting them.
Checklist
repo#issue: Titletitle format and these 7 rules