Fix spurious auto-save #3234
Merged
Fix spurious auto-save #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing a report without sensitive information text, the report would be auto-saved even when no changes were made, because the sensitive information text would be changed from `null` to the empty string `""`. This change keeps the text at `null` in this case.
Inside the form, set the auto-save settings as the first thing, so the change of auto-saving out-of-date values is slightly reduced. Also simplify the assignment.
gjvoosten
requested review from
VassilIordanov,
maradragan,
cemalettin-work and
a team
VassilIordanov
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a report without sensitive information text, the report would be auto-saved even when no changes were made, because the sensitive information text would be changed from
nullto the empty string"".This change keeps the text at
nullin this case.User changes
Super User changes
Admin changes
System admin changes
Checklist
repo#issue: Titletitle format and these 7 rules