Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required value prop failing on null values #3227

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

cemalettin-work
Copy link
Contributor

AdvancedSingleSelect component's value prop being required makes it fail on null values. The component was already setting null value when selection was removed, which breaks a lot of parts

User changes

Super User changes

Admin changes

System admin changes

  • anet.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@VassilIordanov VassilIordanov self-requested a review October 2, 2020 10:18
@VassilIordanov VassilIordanov merged commit 81af7b2 into candidate Oct 2, 2020
@VassilIordanov VassilIordanov deleted the fix-advancedSingleSelect branch October 2, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants