Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'now' instead of the end-of-day in UTC #3222

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

gjvoosten
Copy link
Collaborator

For the cut-off datetime in deciding if something is a future (planned) engagement, use the current datetime, instead of the end-of-day in UTC, which in some cases would lead to engagements being changed to 'draft' status on the wrong day.

Release notes

Fixes #3220

User changes

  • E-mail messages informing the author that their planned engagement report has received 'draft' status are now sent shortly after the start of the meeting, instead of possibly on the wrong day.

Super User changes

  • none

Admin changes

  • none

System admin changes

  • none
  • anet.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

For the cut-off datetime in deciding if something is a future (planned) engagement, use the current datetime.
This instead of the end-of-day in UTC, which in some cases would lead to engagements being changed to draft on the wrong day.
@VassilIordanov VassilIordanov merged commit 025c266 into candidate Sep 30, 2020
@VassilIordanov VassilIordanov deleted the GH-3220-use-now branch September 30, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading planned->happened transition
2 participants