GH 3042 Add MGRS coordinate format #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 3f167de into 57532b7 - view on LGTM.com new alerts:
|
ysf-simsoft
force-pushed
the
GH-3042-add-mgrs-coordinate-format
branch
from
3f167de to
1396fee
Compare
ysf-simsoft
force-pushed
the
GH-3042-add-mgrs-coordinate-format
branch
from
1396fee to
23c75c9
Compare
ysf-simsoft
force-pushed
the
GH-3042-add-mgrs-coordinate-format
branch
from
23c75c9 to
c131dda
Compare
maradragan
suggested changes
Jun 29, 2020
ysf-simsoft
force-pushed
the
GH-3042-add-mgrs-coordinate-format
branch
from
c131dda to
79f0547
Compare
14 tasks
ysf-simsoft
force-pushed
the
GH-3042-add-mgrs-coordinate-format
branch
2 times, most recently
from
05d7ab6 to
ef8fce5
Compare
ysf-simsoft
force-pushed
the
GH-3042-add-mgrs-coordinate-format
branch
2 times, most recently
from
e4fdcfd to
7436628
Compare
maradragan
reviewed
Aug 5, 2020
ysf-simsoft
force-pushed
the
GH-3042-add-mgrs-coordinate-format
branch
from
7436628 to
8dca8d3
Compare
maradragan
approved these changes
Aug 28, 2020
Coordinates are still stored as Lat,Lon format. No changes have been made in backend or DB Schema. We simply convert between MGRS and Lat,Lon while displaying/editing coordinates.
ysf-simsoft
force-pushed
the
GH-3042-add-mgrs-coordinate-format
branch
from
8dca8d3 to
ed28f0a
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MGRS coordinate format support. System admin can define which format to use through the dictionary. Currently two formats are supported: MGRS and LAT_LON. LAT_LON is the default when no format is specified or an unknown format is defined in the dictionary.
Coordinates are still stored as lat,lon values. However, when displaying/editing locations we will convert between lat,lon and the specified format behind the scenes.
Release notes
Closes #3042 and 1st and 2nd items from #244
User changes
Super User changes
Admin changes
System admin changes
System admin can define which coordinate format to be used throughout the UI in anet.yml.
anet.yml needs change
db needs migration
documentation has changed
graphql schema has changed
Checklist
repo#issue: Titletitle format and these 7 rules