Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing key strokes when using ANET search data fields #767

Closed
dspCarlson opened this issue Jul 26, 2018 · 4 comments
Closed

Missing key strokes when using ANET search data fields #767

dspCarlson opened this issue Jul 26, 2018 · 4 comments
Assignees
@gjvoosten
Labels
bug

Comments

@dspCarlson
Copy link

When typing in any data field that has the magnifying glass/search icon, key strokes will be missed.
@dspCarlson dspCarlson added the bug label Jul 26, 2018
@VassilIordanov
Copy link
Contributor

VassilIordanov commented Jul 27, 2018 •
edited
Loading

I was looking at this but I don't think that this is happening: moroshko/react-autosuggest#494
It seems to me that on some keystrokes onChange is not invoked

@VassilIordanov
Copy link
Contributor

it seems like it is happening as the bug in react has been reintroduced in 16.4.1: facebook/react#7027

@gjvoosten
Copy link
Collaborator

gjvoosten commented Jul 31, 2018 •
edited
Loading

In my experiments, occasionally keystrokes were dropped while the list of retrieved suggestions was being rendered. When retrieving 250 suggestions instead of the normal 25, this was slightly more often the case.
I've made some changes to the autocomplete state handling and the suggestion rendering that (at least in my experiments) made the dropping of keystrokes quite rare. But we'll just have to see whether this helps.
Note that only IE11 would drop keystrokes; I was unable to get either Firefox or Chrome do that.

@gjvoosten gjvoosten self-assigned this Jul 31, 2018
gjvoosten added a commit that referenced this issue Jul 31, 2018
@gjvoosten
#767: Optimise autosuggest rendering
67a18af 
Remove some unused state, and optimise the rendering of suggestions a bit.
Attempts to address dropped keystrokes under IE11 as stated in #767
gjvoosten added a commit that referenced this issue Jul 31, 2018
@gjvoosten
#767: Optimise autosuggest rendering
f3b8c81 
Remove some unused state, and optimise the rendering of suggestions a bit.
Attempts to address dropped keystrokes under IE11 as reported in #767
@gjvoosten gjvoosten mentioned this issue Jul 31, 2018
Merged
gjvoosten added a commit that referenced this issue Aug 1, 2018
@gjvoosten
#767: Optimise autosuggest rendering
add0d20 
Remove some unused state, and optimise the rendering of suggestions a bit.
Attempts to address dropped keystrokes under IE11 as reported in #767
VassilIordanov added a commit that referenced this issue Aug 1, 2018
@VassilIordanov
Merge pull request #773 from NCI-Agency/GH-767
87fd2db 
#767: Optimise autosuggest rendering
@dspCarlson
Copy link
Author

This annoying bug is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjvoosten gjvoosten

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gjvoosten @dspCarlson @VassilIordanov