updated error message checks in tests that rely on assertthat::has_name #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Also passed tests locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We are currently in the process of updating
assertthat(hadley/assertthat#59) and found that recent changes (namely hadley/assertthat#60) toassertthat::has_name()break you existing unit tests. Will you please consider this PR to adjust your test strategy?Basically,
has_name()previously had inconsistent behavior when given multiple names to check. That has been corrected and while correcting it, I slightly changed the error message raised byassert_that(has_name(...))calls.I've confirmed that the slight change I'm proposing in this PR will allow your unit tests to pass with the current version of
assertthaton CRAN (0.2.0) AND with the new version (0.2.1) when it is released.