Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codyn 2.0.4 failing CRAN checks #122

Closed
mbjones opened this issue Nov 24, 2020 · 3 comments
Closed

codyn 2.0.4 failing CRAN checks #122

mbjones opened this issue Nov 24, 2020 · 3 comments
Labels
Milestone

Comments

@mbjones
Copy link
Member

mbjones commented Nov 24, 2020

The current codyn CRAN release (2.0.4) has started failing CRAN checks for some reason. See: https://cran.r-project.org/web/checks/check_results_codyn.html

The CRAN maintainers wrote and said:

Please correct before 2020-12-08 to safely retain your package on CRAN.

Any help on maintenance would be appreciated @laurenmh @itcarroll @mavolio . I haven't looked into what is failing and why. Thanks!

@mbjones mbjones added this to the 2.1.0 milestone Nov 24, 2020
@mbjones
Copy link
Member Author

mbjones commented Nov 25, 2020

I ran the codyn checks without error under RHub using R-devel:

  • fedora-clang-devel: R Under development (unstable) (2020-10-24 r79367) (x86_64-pc-linux-gnu (64-bit))
  • fedora-gcc-devel: R Under development (unstable) (2020-10-24 r79367) (x86_64-pc-linux-gnu (64-bit))

Both passed, but RHub is for some reason using r79367 of R-devel, whereas the CRAN check page output is using R Under development (unstable) (2020-11-23 r79474), so I need to figure out how to get RHub to use the most recent R-devel release -- that will likely reproduce the issue. The RHub build grabs the most recent R-devel from subversion, so I am perplexed why it didn't grab something more recent. Any thoughts @gaborcsardi on how to force Rhub to use a more recent version?

N.B. I spent about two hours debugging why RHub wouldn't build this locally for me and failed on the BioConductor install, and I finally found r-hub/rhub#390 and r-hub/rhub#391 -- so the problem has been fixed but is not released to CRAN -- so install from github r-hub/rhub before trying any of these builds with local_check_linux(image="rhub/fedora-gcc-devel") and the like!

@gaborcsardi
Copy link

The images are updated on every weekend.

@itcarroll
Copy link
Collaborator

Appears there is an upcoming change to get that changes behavior to raise an error. Based on the CRAN check results, this is likely the cause of our error. Investigating under r-devel presently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants