Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running attention_net_validation_loss #8

Merged
merged 40 commits into from
Dec 9, 2020
Merged

Running attention_net_validation_loss #8

merged 40 commits into from
Dec 9, 2020

Conversation

ggantos
Copy link
Collaborator

@ggantos ggantos commented Nov 10, 2020

tags about where to look are coming after our one-on-one @djgagne, @jsschreck

ggantos added 30 commits October 8, 2020 19:56
@ggantos
running and evaluation of attention model
1c16216
@ggantos
commit before Pycharm
20190ae
@ggantos
running hyperparameter tuning
3ac6758
@ggantos
adding validation loss function
7c57776
@ggantos
losses unit test and fixed loss calcs
849b0ff
@ggantos
ready to start test runs for attn model
221af10
@ggantos
getting attn running
c6995ad
@ggantos
getting attention net loss to work with correct shape
d0717a0
@ggantos
working on losses_test
b4fd4d6
@ggantos
adding optuna objective function
50ca278
@ggantos
running optuna on casper
61192fe
@ggantos
adding callbacks to optuna
8c43751
@ggantos
adding callbacks to objective.py
788d0b8
@ggantos
fixing losses.py
9e27f5b
@ggantos
fixing optuna callback
7d3d105
@ggantos
adding get_callbacks import
f764cca
@ggantos
fixing callback bug
6465d1a
@ggantos
fixing small typos
fc47701
@ggantos
True for gpu
6aac819
@ggantos
running attention
fd586f0
@ggantos
running attention with attention_net_validation_loss
f8c456b
@ggantos
getting Optuna running
88348e5
@ggantos
deleteing unnecessary notebook
ecec712
@ggantos
plotting evaluation of net_attention_validation_loss function
1adeabd
@ggantos
adding saves to objective.py
9bb3723
@ggantos
adding in xarray import
3ad21a6 
:
@ggantos
adding imports
a98720f
@ggantos
adding more imports
2fba929 
:
@ggantos
adding even more imports
2306388
@ggantos
running attn tests
eb41bc4
djgagne
djgagne reviewed Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@djgagne djgagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loss function names need to be propagated across modules and tests. Otherwise I just to see if the the loss we discussed this week make any difference before merging.

djgagne
djgagne approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@djgagne djgagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving and merging. We will need to go in a different direction since the particle attention net has not panned out sadly.

@djgagne djgagne merged commit 89bf6e3 into master Dec 9, 2020
@ggantos
Copy link
Collaborator Author

ggantos commented Dec 9, 2020

sounds good - thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djgagne djgagne djgagne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggantos @djgagne @guwa4340