Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Contourf to experimental #83

Merged
merged 8 commits into from
Jul 25, 2022
Merged

Move Contourf to experimental #83

merged 8 commits into from
Jul 25, 2022

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Jul 15, 2022

Addresses #82

Summary of changes:

  • removes Contourf and NCL_Plot from main
  • changes remain on experimental branch, which the experimental branch on geocat-examples will pull from
  • makes corresponding changes to docs

Note: will break upstream CI until corresponding changes in geocat-examples are completed (@hCraker ping me when this is good for merge)

@hCraker
Copy link
Contributor

hCraker commented Jul 25, 2022

@anissa111 You should be good to merge this now!

An experimental branch in geocat-examples has been created and it specifically points to the experimental branch here. The main geocat-examples branch no longer references Contourf

@anissa111 anissa111 marked this pull request as ready for review July 25, 2022 19:28
@anissa111 anissa111 requested review from michaelavs and hCraker July 25, 2022 19:28
Copy link
Contributor

@hCraker hCraker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@anissa111 anissa111 merged commit 843b6c3 into main Jul 25, 2022
@anissa111 anissa111 deleted the move_contour branch July 25, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants