Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PypI Trusted Publishing #208

Merged
merged 3 commits into from
Feb 7, 2024
Merged

PypI Trusted Publishing #208

merged 3 commits into from
Feb 7, 2024

Conversation

erogluorhan
Copy link
Collaborator

@erogluorhan erogluorhan commented Feb 7, 2024

PR Summary

Closes #183

Re reviewers:

Sorry, I forgot to create this from a fork. Please let me know if we are good or I still need to do that.

Overview

This PR just removes the PyPI secret from the pypi.yaml action since we've added repo as a trusted publisher on PyPI:

image

Once PyPi releases start to work with this and the first one succeed, we should be good to remove the secret from the repo settings.

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@erogluorhan erogluorhan added enhancement New feature or request developer feature For development standardization / best practices / enhancement ready for review Development is done and ready for reviews release labels Feb 7, 2024
@kafitzgerald kafitzgerald merged commit f5880be into main Feb 7, 2024
@kafitzgerald kafitzgerald deleted the pypi-trusted-publish branch February 7, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer feature For development standardization / best practices / enhancement enhancement New feature or request ready for review Development is done and ready for reviews release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to Trusted Publishing for PyPI
3 participants