Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julyexamples2 #145

Merged
merged 9 commits into from
Jul 27, 2023
Merged

Julyexamples2 #145

merged 9 commits into from
Jul 27, 2023

Conversation

jukent
Copy link
Collaborator

@jukent jukent commented Jul 13, 2023

find_local_extrema()
plot_contour_labels()
plot_extrema_labels()

Related to #126

@jukent
Copy link
Collaborator Author

jukent commented Jul 20, 2023

I need to track down "posx and posy should be finite values" output in plot_extrema_values.ipynb

@jukent jukent requested a review from kafitzgerald July 20, 2023 14:50
@jukent jukent self-assigned this Jul 20, 2023
Copy link
Collaborator

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for the most part.

Obviously the "posx and posy should be finite values" would be good to sort out. Sounds like you're already looking into that though.

I also noticed the notebook cells haven't been cleared and I think we have them set to execute as we build now, right? Having the notebook outputs in there just bloats the notebooks/repo a bit and makes diffs a good bit harder to read. Just makes me nervous given the number of them we'll be including.

@jukent jukent requested a review from kafitzgerald July 20, 2023 17:23
@jukent jukent marked this pull request as ready for review July 20, 2023 17:23
@jukent
Copy link
Collaborator Author

jukent commented Jul 26, 2023

Code now raises a UserWarning that specifies which locations are failing to be transformed, but still automatically drops them. This warning can be suppressed, which is done in this example.

@jukent jukent merged commit ef93ccc into NCAR:main Jul 27, 2023
@jukent jukent deleted the julyexamples2 branch July 27, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants