Add fx for height from pressure axis #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
anissa111
reviewed
Apr 25, 2023
There was a problem hiding this comment.
I think I'd still like more discussion on the style standardization of the docstring, but given that's currently being made into a separate PR, I'll drop it here.
My only point is that the returns aren't showing up on the rendered docstring. I don't have any idea why, but that should probably be taken care of here.
Comment on lines
+209
to
+212
| Return: | ||
|
|
||
| axRHS (:class:`matplotlib.axes._subplots.AxesSubplot` or :class:`cartopy.mpl.geoaxes.GeoAxesSubplot`): | ||
| The created right-hand axis |
There was a problem hiding this comment.
Not sure why, but the docs aren't picking up this part
There was a problem hiding this comment.
Hmm in other places I saw the docs doing weird things with return and return types. I will tackle this in the docstring overhaul.
anissa111
reviewed
Apr 25, 2023
anissa111
reviewed
Apr 25, 2023
philipc2
requested changes
Apr 25, 2023
Co-authored-by: Philip Chmielowiec <67855069+philipc2@users.noreply.github.com>
Co-authored-by: Anissa Zacharias <anissaz@ucar.edu>
Co-authored-by: Philip Chmielowiec <67855069+philipc2@users.noreply.github.com>
philipc2
approved these changes
Apr 26, 2023
|
Great thanks @philipc2! @anissa111 I'm going to merge this now and will request your review on documentation things in my next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #108