Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAS deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif) to CCPP #3

Merged
merged 12 commits into from
Nov 20, 2019

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Nov 18, 2019

This PR is associated and tested with the PRs listed below. For regression testing, see NCAR/ufs-weather-model#3.

Changes for fv3atm:

  • Add sas shallow/deep convection schemes and satmedmfvdifq scheme to CCPP
  • Add new SDFs for sas and satmedmfvdifq, remove samfshalcnv_post scheme from existing suites
  • Bit-for-bit identical results on macOS+GNU with 32bit dynamics, cleanup bitforbit compiler options for CCPP
  • Update CCPP annotations in gfsphysics/GFS_layer/GFS_physics_driver.F90
  • Suppress warnings about non-existing include directories for GNU

@climbfuji
Copy link
Collaborator Author

climbfuji commented Nov 18, 2019

@climbfuji climbfuji force-pushed the ccpp_add_sas_and_satmedmfvdifq branch from 567fd3f to a333ffc Compare November 19, 2019 21:48
@climbfuji climbfuji marked this pull request as ready for review November 20, 2019 14:43
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can make the associated changes to SCM. BTW, I'm glad that the shallow convection interstitials were rearranged as they were. They are now consistent with how deep convection is done, I think. The previous arrangement of using the samfshalcnv_post as a scheme-specific scheme was a product of other shallow convection schemes not being made CCPP-compliant yet IIRC.

@climbfuji climbfuji merged commit 332fb61 into NCAR:dtc/develop Nov 20, 2019
dustinswales referenced this pull request in dustinswales/fv3atm Nov 21, 2019
climbfuji pushed a commit that referenced this pull request Dec 3, 2019
…eflectivity to restart file and restart reproducibility for regional fv3,3)ufs issue #5, Updates to WW3, 4)vlab #69735, update netcdf time units attribute when iau_offset
climbfuji pushed a commit that referenced this pull request Apr 3, 2020
…le_update

Feature/add km ccpp submodule update
climbfuji pushed a commit that referenced this pull request Jun 16, 2020
climbfuji added a commit that referenced this pull request Jul 30, 2020
Rename or clean up some HAFS hwrf physics related SDFs
SamuelTrahanNOAA referenced this pull request in SamuelTrahanNOAA/fv3atm Sep 9, 2021
Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
mzhangw pushed a commit to mzhangw/fv3atm that referenced this pull request Sep 21, 2021
modification to add extra land fields to the output
SamuelTrahanNOAA referenced this pull request in SamuelTrahanNOAA/fv3atm Jan 7, 2022
change ifmin to zero at fh00 for inline POST (NCAR#14)
grantfirl pushed a commit to grantfirl/fv3atm that referenced this pull request Feb 25, 2022
remove GFS_suite_interstsitial_3/4 from FV3_RRFS_v1nssl suite
grantfirl pushed a commit to grantfirl/fv3atm that referenced this pull request Mar 13, 2023
Allow HAFS app to be compiled with 64bit FMS (NOAA-EMC#626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants