Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version of "Move parse_tracers file from physics to host" #569

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Mar 18, 2025

Original description/work from @dustinswales:

This PR moves the GFDL_parse_tracers file from the physics to the host (where it belongs)
Also, is a small bugfix in a plotting script.

@grantfirl update:

  • remove parse_tracers module entirely since we can use a local version of get_tracer_index() already in SCM code
  • move get_tracer_index() function from scm_type_defs to GFS_typedefs to avoid circular dependency

…racers.F90 that has been removed from ccpp-physics and moved from scm_type_defs.F90 to avoid circular dependencies
@grantfirl
Copy link
Collaborator Author

@mkavulich @scrasmussen @hertneky @dustinswales This introduces another "delta" between the fv3atm and SCM version of GFS_typedefs. The fv3atm version (PR to come) will use get_tracer_index() from FMS (which is not used in SCM) like the rest of fv3atm instead of the previously included version from GFDL_parse_tracers in ccpp-physics.

@grantfirl grantfirl marked this pull request as ready for review March 18, 2025 22:56
@grantfirl
Copy link
Collaborator Author

Replaces #520

Copy link
Member

@scrasmussen scrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over changes, get_tracer_index is an equivalent and slightly cleaner version to the one removed from the ccpp-physics repo. Looks good and compiles!

@grantfirl
Copy link
Collaborator Author

The same RTs from #566 are expected to change results here since new baselines haven't been uploaded to mohawk yet.

@grantfirl
Copy link
Collaborator Author

New baseline artifacts from https://github.com/NCAR/ccpp-scm/actions/runs/13975876703 need to be uploaded when @scrasmussen @hertneky @mkavulich gets a chance.

@grantfirl grantfirl merged commit 2e0a3ad into NCAR:main Mar 20, 2025
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants