Capgen in scm #522
Draft
Capgen in scm #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e as the module, which was causing problems in Capgen where flat-fields are passed from the API to the suite caps (e.g. the argument lsm_noah is now a problem in the lsm_noah module, when GFS_control%lsm_noah was not a conflict
dustinswales
commented
Mar 13, 2025
There was a problem hiding this comment.
@climbfuji Here's the snippet that I added to the SDF which you could drop into the rest of them. Just if you agree, and to avoid a future conflict.
climbfuji
reviewed
Mar 13, 2025
| <!-- End process-split section --> | ||
| <!-- Begin time-split section --> | ||
| <group name="physics_ts"> | ||
| <subcycle loop="1"> | ||
| <scheme>GFS_suite_stateout_update</scheme> |
There was a problem hiding this comment.
Should the GFS_suite_stateout_update be part of the process_split group? Seems more logical to me that the process split group at the end updates the state from all the processes (this is also what the framework will do automatically in the future)?
There was a problem hiding this comment.
Yeah, that makes more sense.
dustinswales
force-pushed
the
capgen_in_scm
branch
from
4544982 to
2fdcbda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for CCPP SCM changes needed for transition to Capgen.
Work in progress