Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccpp-physics cleanup 20180402 #66

Merged
merged 1 commit into from
Apr 3, 2018
Merged

ccpp-physics cleanup 20180402 #66

merged 1 commit into from
Apr 3, 2018

Conversation

climbfuji
Copy link
Collaborator

This PR performs cleanup tasks: add initialization of CCPP error handling variables in physics/mfdeepcnv.f.

@climbfuji
Copy link
Collaborator Author

TODO: test if this changes bit-for-bit results with FV3

@climbfuji
Copy link
Collaborator Author

UPDATE: results are bit-for-bit identical on Cheyenne with Intel compiler. @llpcarson @grantfirl shall we play safe and wait for Theia to return from the maintenance for a final test?

@llpcarson
Copy link
Contributor

I recommend we proceed --- the theia test can be completed before we push this to master.

Copy link
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@climbfuji climbfuji merged commit 56a171a into NCAR:release Apr 3, 2018
llpcarson pushed a commit to llpcarson/ccpp-physics that referenced this pull request Dec 22, 2020
…ter_20201203

Update gsl/develop from master 2020/12/08
HelinWei-NOAA referenced this pull request in HelinWei-NOAA/ccpp-physics Feb 26, 2023
…he P8 physics suite) (NCAR#592)

* This is equivalent to PR66 in NCAR/fv3atm: NCAR/main PR #66 (Bugfix and optimization of prognostic closure for the P8 physics suite)
mkavulich pushed a commit to mkavulich/ccpp-physics that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants