Use threading to speed up MERRA2 aerosol interpolation and NoahMP initialization #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reading_aerosol_interp_noahmp_init
climbfuji
changed the title
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
|
Dom, I will check out the code and test it soon. Thank you and have a great
weekend, --Anning
…On Fri, Apr 2, 2021 at 12:28 PM Dom Heinzeller ***@***.***> wrote:
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> FYI
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#605 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMINUQPR4LADYLKWH74TTGXWBZANCNFSM42IDL4KA>
.
|
barlage
approved these changes
Apr 7, 2021
|
HI, Dom:
I issue the following command to clone the trunk, but get " fatal: Needed a
single revision
Unable to find current origin/master revision in submodule path 'icepack' "
git clone --recursive https://github.com/ufs-community/ufs-weather-model
cd ufs-weather-model
git submodule update --init --recursive --remote
The compilation is also not passed by using "compile.sh orion.intel "CCPP=Y
32BIT=Y SUITES=FV3_GFS_v15,FV3_GFS_v16beta" 2 YES NO".
/work/noaa/global/acheng/ufs-weather-model/tests/build_fv3_2/CMakeFiles/CMakeOutput.log,
something wrong with the Cmake.
Do I miss something?
Anning
On Fri, Apr 2, 2021 at 12:44 PM Anning Cheng - NOAA Affiliate <
***@***.***> wrote:
… Dom, I will check out the code and test it soon. Thank you and have a
great weekend, --Anning
On Fri, Apr 2, 2021 at 12:28 PM Dom Heinzeller ***@***.***>
wrote:
> @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> FYI
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#605 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALQPMINUQPR4LADYLKWH74TTGXWBZANCNFSM42IDL4KA>
> .
>
|
Anning, this has nothing to do with this PR, since you are not even checking out this code. The compile command has changed, please look inside |
|
HI, Dom:
I have not found PR#604 at https://github.com/NCAR/ccpp-physics/pulls. Is
it in trunk now?
Anning
On Thu, Apr 8, 2021 at 9:28 AM Dom Heinzeller ***@***.***>
wrote:
… HI, Dom: I issue the following command to clone the trunk, but get "
fatal: Needed a single revision Unable to find current origin/master
revision in submodule path 'icepack' " git clone --recursive
https://github.com/ufs-community/ufs-weather-model cd ufs-weather-model
git submodule update --init --recursive --remote The compilation is also
not passed by using "compile.sh orion.intel "CCPP=Y 32BIT=Y
SUITES=FV3_GFS_v15,FV3_GFS_v16beta" 2 YES NO".
/work/noaa/global/acheng/ufs-weather-model/tests/build_fv3_2/CMakeFiles/CMakeOutput.log,
something wrong with the Cmake. Do I miss something? Anning On Fri, Apr 2,
2021 at 12:44 PM Anning Cheng - NOAA Affiliate < *@*.***> wrote:
… <#m_1459518316675935679_>
Anning, this has nothing to do with this PR, since you are not even
checking out this code. The compile command has changed, please look inside
rt.sh for the updated syntax.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#605 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMINHF6VNAAAHAAMYNHDTHWVRDANCNFSM42IDL4KA>
.
|
|
No, it is still open as you can see from this page. We don't have a date scheduled yet.
… On Apr 8, 2021, at 7:41 AM, AnningCheng-NOAA ***@***.***> wrote:
HI, Dom:
I have not found PR#604 at https://github.com/NCAR/ccpp-physics/pulls. Is
it in trunk now?
Anning
On Thu, Apr 8, 2021 at 9:28 AM Dom Heinzeller ***@***.***>
wrote:
> HI, Dom: I issue the following command to clone the trunk, but get "
> fatal: Needed a single revision Unable to find current origin/master
> revision in submodule path 'icepack' " git clone --recursive
> https://github.com/ufs-community/ufs-weather-model cd ufs-weather-model
> git submodule update --init --recursive --remote The compilation is also
> not passed by using "compile.sh orion.intel "CCPP=Y 32BIT=Y
> SUITES=FV3_GFS_v15,FV3_GFS_v16beta" 2 YES NO".
> /work/noaa/global/acheng/ufs-weather-model/tests/build_fv3_2/CMakeFiles/CMakeOutput.log,
> something wrong with the Cmake. Do I miss something? Anning On Fri, Apr 2,
> 2021 at 12:44 PM Anning Cheng - NOAA Affiliate < *@*.***> wrote:
> … <#m_1459518316675935679_>
>
> Anning, this has nothing to do with this PR, since you are not even
> checking out this code. The compile command has changed, please look inside
> rt.sh for the updated syntax.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#605 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALQPMINHF6VNAAAHAAMYNHDTHWVRDANCNFSM42IDL4KA>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#605 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RLTQPSJ46GZSY5OOHTTHWW67ANCNFSM42IDL4KA>.
|
…reading_aerosol_interp_noahmp_init
llpcarson
approved these changes
Apr 14, 2021
grantfirl
approved these changes
Apr 14, 2021
XiaSun-Atmos
approved these changes
Apr 14, 2021
HelinWei-NOAA
pushed a commit
to HelinWei-NOAA/ccpp-physics
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR speeds up the merra2 aerosol interpolation and Noah MP initialization using threading in
GFS_phys_time_vary.fv3.F90.Tests conducted:
aerinterpolwhen using 4 OpenMP threads.Fixes #608
Testing
See ufs-community/ufs-weather-model#507
Dependencies
#605
NOAA-EMC/fv3atm#268
ufs-community/ufs-weather-model#507