Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmtb-gfsphysics scm integration: build system update #55

Merged
merged 1 commit into from
Mar 23, 2018
Merged

gmtb-gfsphysics scm integration: build system update #55

merged 1 commit into from
Mar 23, 2018

Conversation

climbfuji
Copy link
Collaborator

This PR contains an update of CMakeLists.txt:

  • activate RPATH on MACOSX
  • change default build type to 'Release'
  • fix detecting OpenMP flags for Fortran
  • fix passing on compiler flags
  • raise exception for unsupported compiler

SCM+CCPP runs tested on Theia/Intel, Cheyenne/Intel, Macbook/GNU (no bit for bit tests)
FV3+CCPP runs tested on Theia/Intel, Theia/GNU, Macbook/GNU (with bit for bit tests)

…ild type to 'Release', fix detecting OpenMP flags for Fortran, fix passing on compiler flags, raise exception for unsupported compiler
Copy link
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I appreciate the changes to the cmake config -- especially CMAKE_MACOSX_RPATH 1. I really appreciate not having to specify the path to the physics library anymore.

@climbfuji climbfuji merged commit 19fa220 into NCAR:features/ccpp Mar 23, 2018
@climbfuji climbfuji deleted the gmtb-gfsphysics-build-system-fixes branch March 23, 2018 19:18
climbfuji pushed a commit to climbfuji/ccpp-physics that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants