Updated rte-rrtmgp submodule #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinswales
requested review from
climbfuji,
grantfirl,
JulieSchramm and
llpcarson
as code owners
|
I have run this with the SCM using 127 levels successfully. I'm guessing that this will need to be tested in FV3 in order to be merged into master? |
|
I believe this is the case. Should we also set up a RT for the 127 layer case with RRTMGP? |
From today's email chain from Robert and Lisa, I'm guessing so, but this needs to be worked out with Dom, Jun, and Dusan, I think (whether it can go to develop at least). I don't see any harm in creating at least one L127+RRTMGP RT in a branch of ufs-weather-model at least. |
This was referenced Dec 10, 2020
HelinWei-NOAA
pushed a commit
to HelinWei-NOAA/ccpp-physics
that referenced
this pull request
Feb 26, 2023
* update downstream submodules * updating ccpp/physics submodule and coupling fields * update ccpp/physics submodule, restart capability * Update submodules and restart files * updates submodule * addressing some review comments * update submodules fetch upstream * update ccpp/physics submodule * change conditional check to <= for saftey * addressing some review comments * removing wclosureflg * Allow CA to run on non-uniform blocksizes * cleaning and updating submodules * updating submodules * update atmos_cubed_sphere * updating submodule atmos_cubed_sphere * .gitmodules * updating atmos_cubed_sphere * updating submodules * merge with develop * merging with submodules * updating ccpp/framework and upp submodules * address some review comments, bug in active, correct initialization in ccpp/physics * put back some diagnostic fields * merge upstream cppp/physics * resolving some conflicts * remove check to allow CA to be used with non-divisible blocksize * Add active flag for conditional variables in meta data, update ccpp/physics submodule * merge submodule ccpp/physics upstream * merge with ccpp/physics main * revert .gitmodules and add the merged ccpp/physics code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix in rte-rrtmgp to use 127-layers for the UFS.