Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change delz dimension corresponding to the change in atmos_cubed_sphere #397

Merged
merged 9 commits into from
Jun 9, 2020

Conversation

XiaqiongZhou-NOAA
Copy link
Contributor

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA commented Feb 13, 2020

To update FV3 dynamic core, change delz dimension corresponding to the change in atmos_cubed_sphere

Related pull requests:
atmos_cubed_sphere #15
universe-weather-model #58
fv3atm #65

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also needs to be updated with the latest version of NCAR ccpp-physics master.

physics/gfdl_fv_sat_adj.F90 Show resolved Hide resolved
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks! Will approve when regression tests passed.

@climbfuji
Copy link
Collaborator

@grantfirl @llpcarson @XiaqiongZhou-NOAA in case the dycore merge PRs make it to the top of the commit queue during my two days of vacation, please communicate with each other to approve and merge this PR. Also talk to @DusanJovic-NOAA and @junwang-noaa. Thanks!

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code in PR has been updated with the latest changes from master, approved.

@climbfuji climbfuji merged commit 693d001 into NCAR:master Jun 9, 2020
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
* update ccpp with decomposition fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants