-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change delz dimension corresponding to the change in atmos_cubed_sphere #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR also needs to be updated with the latest version of NCAR ccpp-physics master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks! Will approve when regression tests passed.
@grantfirl @llpcarson @XiaqiongZhou-NOAA in case the dycore merge PRs make it to the top of the commit queue during my two days of vacation, please communicate with each other to approve and merge this PR. Also talk to @DusanJovic-NOAA and @junwang-noaa. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code in PR has been updated with the latest changes from master, approved.
* update ccpp with decomposition fix
To update FV3 dynamic core, change delz dimension corresponding to the change in atmos_cubed_sphere
Related pull requests:
atmos_cubed_sphere #15
universe-weather-model #58
fv3atm #65