Fix longname conflicts 20180110/2 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to Diag%dq3dt(:,:,4)
…schemes, changed units from logical to flag
… fix_longname_conflicts
…ry, changed unit for horizontal_loop_extent and horizontal_dimension from index to count; fixed time units from hr to h
SamuelTrahanNOAA
pushed a commit
that referenced
this pull request
Jun 30, 2022
rewrite the code and make thermal roughness scheme as a subroutine
lisa-bengtsson
pushed a commit
to lisa-bengtsson/ccpp-physics
that referenced
this pull request
Mar 6, 2023
NCAR-main PR#956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses further inconsistencies and conflicts in the metadata tables. Specifically, units of horizontal_loop_extent and horizontal_dimension are corrected. Further, a bugfix in the calling arguments to GFS_MP_generic_post_run is included, and units for hours are corrected from hr to h.
Results bfb identical, tested on Cheyenne.