gmtb/develop: follow-up PR for GSD drag suite #327
Conversation
climbfuji
force-pushed
the
drag_suite_dom
branch
from
2d9cf77 to
5b7201d
Compare
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
| !! \brief This subroutine includes orographic gravity wave drag, mountain | ||
| !! blocking, and form drag. | ||
| !! | ||
| !> The time tendencies of zonal and meridional wind are altered to |
There was a problem hiding this comment.
@mdtoy Fantastic write-up. Thanks!
| !! \section general General Algorithm | ||
| !! \section detailed Detailed Algorithm | ||
| !! @{ | ||
| subroutine drag_suite_pre_run( & |
There was a problem hiding this comment.
It looks to me like the entire functionality of drag_suite_pre_run subroutine already exists in a "generic" interstitial: GFS_GWD_generic_pre_run, so this can likely be removed, unless I'm missing something. Instead of calling drag_suite_pre in the SDF, one could just use GFS_GWD_generic_pre, which would then be common amongst the operational, unified GWD, and this scheme.
| !> \section arg_table_drag_suite_post_run Argument Table | ||
| !! \htmlinclude drag_suite_post_run.html | ||
| !! | ||
| subroutine drag_suite_post_run( & |
There was a problem hiding this comment.
This code is also common to gwdps_post_run. I think the reason why this code wasn't put into a GFS_GWD_generic_post (like the code executed prior to calling GWD) was because the unified GWD scheme calculates tendencies differently. Now, it looks like the unified GWD scheme is the "odd man out" and this can be rolled into a GFS_GWD_generic_post subroutine within GFS_GWD_generic.F90. As for the "pre" code above, the drag_suite_post scheme in the SDF would need to be replaced by GFS_GWD_generic_post. It would also be nice to at least investigate putting the unified GWD tendency calculations in there too, although doing so would probably involve ugly conditionals.
Add the hourly maximum precipitation rate in mm/hr for all microphysics schemes and will be used only by regional configurations.
Follow-up PR for #324.
Both PRs combined add the GSD drag suite to CCPP, including a new regression test in the GSD regression test config.
Associated PRs:
#327
https://github.com/NCAR/FV3/pull/211
https://github.com/NCAR/NEMSfv3gfs/pull/258
For regression testing, see https://github.com/NCAR/NEMSfv3gfs/pull/258.