Bugfix RUC LSM ice temperature initialization, landmask/landuse inconsistencies #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
climbfuji
commented
Aug 9, 2019
•
climbfuji
commented
- merge latest SCM-related updates from gmtb/develop into gsd/develop
- bugfix to correctly initialize RUC subsurface/soil properties for non-land points for both Noah and RUC input
- consistency checks to prevent inconsistent landmask / landuse classification settings
- convert print * statements in RUC into write (0,*) statements in line to match other physics schemes
remove loops over nblks in SCM-related GFS_phys_time_vary
… to prevent using unconfigured ivegsrc, add check for inconsistent landmask and landuse classification, correctly initialize RUC subsurface data for non-land points for both Noah and RUC input data
|
These changes still need to be tested on Theia (GSD regression tests) before merging |
|
Associated with https://github.com/NCAR/NEMSfv3gfs/pull/214, see this PR for regression testing information. |
climbfuji
deleted the
bugfix_ruclsm_ice_temp_landmask_landuse_inconsistencies
branch
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
* ensure min positive value for z_bot export field * revert change to z_bot in atmos_model for zbot fix * point to Kate's dycore fix for zbot * add suites * add suite_FV3_GFS_v16_coupled_noahmp.xml and suite_FV3_GFS_v16_coupled_nsstNoahmp.xml suites * remove 'x' permissions on suite_FV3_GFS_v15p2_couplednsst.xml * update dycore submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.