Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsd/develop: add regression tests for Thompson only, GF only, MYNN only & cleanup #285

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jul 17, 2019

Associated PRs:

https://github.com/NCAR/NEMSfv3gfs/pull/206
#285
https://github.com/NCAR/FV3/pull/179

See https://github.com/NCAR/NEMSfv3gfs/pull/206 for testing.

Changes in ccpp-physics:

  • remove option to turn off make_number_concentrations, always this option if number concentrations are not in the initial conditions

@climbfuji climbfuji marked this pull request as ready for review July 17, 2019 21:00
@climbfuji climbfuji merged commit 3c69aa6 into NCAR:gsd/develop Jul 18, 2019
@climbfuji climbfuji deleted the add_regression_tests_20190717 branch June 27, 2022 03:04
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
… consistent (NCAR#285)

   - Update all suite definition files with the new CCPP scheme GFS_radiation_surface
    - Add new arrays for surface albedo and surface emissivity to GFS_typedefs.F90 and to FV3GFS_io.F90
    - Update FV3GFS_io.F90 to write out composite tsfc and zorl for restarts, simplify logic for these two fields
    - Unrelated change: fix a bug when MULTIGASES physics option is set: correctly allocate the rilist and cpilist arrays
    - Unrelated change: remove cnvc90 from ccpp/suites/suite_FV3_GFS_v15_thompson_mynn_lam3km.xml
    - Rename suite FV3_GFS_v16b_ugwpv1 to FV3_GFS_v16_ugwpv1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants