UFS-dev PR#189 #1075
Merged
UFS-dev PR#189 #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in the GFS suite
The ozone photochemistry parametrization is a first-order Taylor expansion of the net ozone production in three variables. This commit changes the four diagnostics the parametrization manages to match the four terms in the Taylor expansion. When comparing to the implementation in lines 301-304, note that it is implicit in the model ozone mixing ratio, so line 301 has the first term and the second half of the second term, while the first half of the second term is part of the denominator on line 304. I could use ozi or ozib for an explicit approximation to that term, but we already calculated the value needed for the implicit calculation actually used for the update.
…ariables but internally bend everything back to where it's expected (affects some, but not all variables)
…stitial_{2,3}.F90
…_SCM_NEPTUNE/GFS_suite_interstitial_2.F90
…oud_mp.F90 and physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_overlap.F90
…previous committ.
Use -O1 instead of -O0 for gcycle.F90 with Intel
… into feature/ccpp_prebuild_opt_args
Update CODEOWNERS
Updated rca calculation with rsmin and rsmax limits.
Combination PR for ozone diagnostics, metadata intent bugfixes, sfcsub.F landmask bugfix, and canopy resistance output
… into feature/ccpp_prebuild_opt_args
grantfirl
requested review from
Qingfu-Liu,
dustinswales and
mzhangw
as code owners
…P, MYJ SFC/PBL, remove F77 continuation formatting
grantfirl
commented
Jun 6, 2024
| @@ -316,7 +316,7 @@ subroutine cu_gf_deep_run( & | |||
| real(kind=kind_phys), dimension (its:ite,kts:kte) :: pwdper, massflx | |||
| integer :: nv | |||
| !$acc declare create(chem,chem_cup,chem_up,chem_down,dellac,dellac2,chem_c,chem_pw,chem_pwd, & | |||
| !$acc chem_pwav,chem_psum,pwdper,massflux) | |||
| !$acc chem_pwav,chem_psum,pwdper,massflx) | |||
There was a problem hiding this comment.
Fixed this for NVidia build.
dustinswales
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
ufs-community#194
ufs-community#205
ufs-community#189
Plus:
-- These were overlooked in Introduce optional arguments in ccpp schemes and metadata ufs-community/ccpp-physics#189 because they are not used in UFS RTs
-- Needed for SCM CI tests