Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UFS-dev PR#184 #1073

Merged
merged 53 commits into from
Jun 4, 2024
Merged

UFS-dev PR#184 #1073

merged 53 commits into from
Jun 4, 2024

Conversation

grantfirl
Copy link
Collaborator

DusanJovic-NOAA and others added 30 commits March 24, 2022 14:45
@DusanJovic-NOAA
Resolve argument mismatch errors when using gfortran
1c6c1d8 
Switch from 'use mpi' to 'use mpi_f08'
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
bd588f9
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
f5c5073
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
a90b957
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
6c87d3e
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
02eb368
@DusanJovic-NOAA
Declare variables passed to w3nco library as double precission
16ef7f2
@DusanJovic-NOAA
More argument mismatch fixes
696c0ea
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
9da6d0e
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
2686cd1
@DusanJovic-NOAA
Merge branch 'ufs/dev' into no_arg_mismatch
d1e061d
@DusanJovic-NOAA
Merge branch 'ufs/dev' into no_arg_mismatch
3302938
@DusanJovic-NOAA
Merge branch 'ufs/dev' into no_arg_mismatch
af99a17
@climbfuji
If MPI is used, find package
92b8c85
@climbfuji
Merge branch 'no_arg_mismatch' of https://github.com/DusanJovic-NOAA/…
6c34d5b 
…ccpp-physics into feature/depend_on_mpi
@DusanJovic-NOAA
Fixed cmake if/endif mismatch
f943d20
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
61e03a8
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
0df1328
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
8c83308
@DusanJovic-NOAA
Use mpi_f08 in rrtmgp_lw_main and rrtmgp_sw_main
347d745
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
13c0276
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
a372112
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
a4054ff
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
c2763f5
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
b4cb573
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
37fd3fb
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
7307e1a
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
bf68db2
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
53d394d
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
8e52a61
DusanJovic-NOAA and others added 20 commits January 16, 2024 19:31
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
531cd86
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
47d4bff
@DusanJovic-NOAA
Change the type of mpi communicator in few more files
bac1994
@DusanJovic-NOAA
Fix mpi use statement
8c68c2f
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
dbef1a7
@DusanJovic-NOAA
Update MPI find_package and check if MPI F08 module is supported
bb9b90f
@DusanJovic-NOAA
Remove C from MPI find_package
0cb5d97
@climbfuji
In physics/Interstitials/UFS_SCM_NEPTUNE/maximum_hourly_diagnostics.m…
e1db7f2 
…eta: change units 'flashes 5 min-1' to 'flashes min-1' and update long name to make clear this is per 5 minutes
@climbfuji
In physics/Interstitials/UFS_SCM_NEPTUNE/maximum_hourly_diagnostics.F…
26f9514 
…90, scale lightning threat from flashes per 5 minutes to flashes per minute to match units in metadata
@SamuelTrahanNOAA
correctly convert from flashes per five minutes to flashes per minute
743dc85
@SamuelTrahanNOAA
correct the meta file
7e74ada
@climbfuji
Merge pull request NCAR#16 from SamuelTrahanNOAA/dom-flash-correctly
c97a968 
correctly convert from flashes per five minutes to flashes per minute
@lisa-bengtsson
Introduce namelist flag to convection/cloud/radiation interaction in …
1497772 
…GFS suite
@grantfirl
Merge pull request NCAR#181 from grantfirl/csawv2_gjf
8dff959 
incorporate csawMG update and pass both intel and GNU RT tests
@climbfuji
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physics…
2f15ae9 
… into HEAD
@grantfirl
Merge pull request NCAR#182 from climbfuji/feature/fix_units_flashes_…
9f4a96b 
…per_5min

Fix units flashes per 5 min
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
94596b3
@dustinswales
Merge pull request NCAR#160 from DusanJovic-NOAA/no_arg_mismatch
9839680 
Resolve various subroutine argument mismatches
@lisa-bengtsson
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physics…
7fa5593 
… into cloudPR
@grantfirl
Merge branch 'cloudPR' into ufs-dev-PR184
a3760b8
@grantfirl grantfirl mentioned this pull request May 23, 2024
Closed
@mkavulich mkavulich mentioned this pull request May 29, 2024
Draft
@mkavulich
Copy link
Collaborator

@grantfirl Does this update require SCM changes as well? When I updated my SCM branch to use this physics branch, prebuild fails with an error:

DEBUG: Requested variable zenith_angle_temporal_adjustment_factor_for_shortwave_fluxes in MODULE_ysuvdif SCHEME_ysuvdif SUBROUTINE_ysuvdif_run matched to target physics%Interstitial%xmu in module CCPP_typedefs
Traceback (most recent call last):
  File "/Volumes/d1/kavulich/CCPP/rename_suite_files/grants_pr/mybranch/ccpp-scm/ccpp/framework/scripts/ccpp_prebuild.py", line 827, in <module>
    main()
  File "/Volumes/d1/kavulich/CCPP/rename_suite_files/grants_pr/mybranch/ccpp-scm/ccpp/framework/scripts/ccpp_prebuild.py", line 783, in main
    raise Exception('Call to compare_metadata failed.')
Exception: Call to compare_metadata failed.

@mkavulich
Copy link
Collaborator

Sorry, I just now saw your comment here, disregard

@grantfirl grantfirl mentioned this pull request May 31, 2024
Merged
@grantfirl grantfirl merged commit 76cf93f into NCAR:main Jun 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qingfu-Liu Qingfu-Liu Qingfu-Liu approved these changes

@dustinswales dustinswales Awaiting requested review from dustinswales dustinswales is a code owner

@mzhangw mzhangw Awaiting requested review from mzhangw mzhangw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@grantfirl @mkavulich @Qingfu-Liu @DusanJovic-NOAA @climbfuji @SamuelTrahanNOAA @lisa-bengtsson @dustinswales