Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capgen automated testing on PRs to "develop" #577

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

peverwhee
Copy link
Collaborator

Updates the github workflows so capgen tests run when a PR is opened into the "develop" branch (in addition to the "main" branch)

User interface changes?: No

Copy link
Collaborator

@mwaxmonsky mwaxmonsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peverwhee!

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now can we make develop the default branch for opening PRs? :)

@peverwhee
Copy link
Collaborator Author

Great, now can we make develop the default branch for opening PRs? :)

@gold2718 I'll add an item to our next framework meeting agenda - I think making PRs default to "develop" will also make "develop" the default branch overall and I'm not sure "we" want to do that!

@gold2718
Copy link
Collaborator

Great, now can we make develop the default branch for opening PRs? :)

@gold2718 I'll add an item to our next framework meeting agenda - I think making PRs default to "develop" will also make "develop" the default branch overall and I'm not sure "we" want to do that!

Yeah, the smiley face is because I think we do not want develop to be the default branch.

@peverwhee peverwhee merged commit 42e892f into NCAR:develop Jul 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants