Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system test for doxygen comments between metadata hooks and CCPP entry point (subroutine) #429

Conversation

climbfuji
Copy link
Collaborator

Add system test for doxygen comments between metadata hooks and CCPP entry point (subroutine) to make sure various doxygen comments and blank lines are parsed correctly/ignored between CCPP metadata hooks and the Fortran subroutines.

Issue #369 reports that certain doxygen comments between the metadata hooks and the subroutines are "not parsed correctly" (i.e. are not ignored). I was going to fix this problem and found that the current capgen metadata parser can handle those cases just fine. I added a CCPP entry point to cover these tests.

User interface changes?: No

"Fixes #369"

Testing:
test removed: None
unit tests: None
system tests: Add one system test to cover blank lines and doxygen comments between metadata hooks and subroutines; note: test/run_tests.sh passes.
manual testing: None

@climbfuji climbfuji requested a review from gold2718 as a code owner January 17, 2022 03:39
Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test to have, thanks.

@climbfuji climbfuji merged commit 0c69a9c into NCAR:feature/capgen Jan 17, 2022
@climbfuji climbfuji deleted the test_doxygen_between_metadata_and_subroutine branch June 27, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants