Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use absolute paths to dependency source code files #575

Closed
mattldawson opened this issue Jul 12, 2024 · 1 comment · Fixed by #576
Closed

Use absolute paths to dependency source code files #575

mattldawson opened this issue Jul 12, 2024 · 1 comment · Fixed by #576
Assignees
@gold2718
Labels
capgen bugs, requests, etc. that involve ccpp_capgen enhancement

Comments

@mattldawson
Copy link

Description

The paths to dependencies in the generated ccpp_datatable.xml file are relative to the folder that holds the scheme files that need them. Because they are included in a separate dependencies element, decoupled from their source scheme, it is difficult to determine the absolute path to these files and include them in the build.

e.g.,:

<ccpp_datatable>
  ...
  <dependencies>
    <dependency>micm/micm.F90</dependency>
  </dependencies>
  ...
</ccpp_datatable>

Solution

Generate absolute paths for dependencies instead. e.g.,:

<ccpp_datatable>
  ...
  <dependencies>
    <dependency>/glade/work/me/CAM-SIMA/somewhere/micm/micm.F90</dependency>
  </dependencies>
  ...
</ccpp_datatable>

This would also be consistent with other paths in this file, which are absolute.

@peverwhee @nusbaume - did I miss anything?

Alternatives (optional)

Alternatively, users could try to infer the absolute paths from other information in ccpp_datatable.xml, but I couldn't figure out a straightfoward way to do this.

Related to (optional)

none
@climbfuji climbfuji added the capgen bugs, requests, etc. that involve ccpp_capgen label Jul 12, 2024
@gold2718 gold2718 mentioned this issue Jul 12, 2024
Merged
@gold2718 gold2718 self-assigned this Jul 12, 2024
gold2718 added a commit that referenced this issue Jul 19, 2024
@gold2718
Use absolute paths for dependencies (#576)
5f338dd 
Use absolute paths for dependencies

In order to make the dependencies in the CCPP datatable more usable,
store absolute pathnames where possible.

User interface changes?: Yes
This may require a change in any build system that uses the
dependencies.

Fixes: #575

Testing:
  test removed: None
  unit tests: passed
  system tests: ?
  manual testing: ran Fortran tests

---------

Co-authored-by: Steve Goldhaber <stevenng@met.no>
@peverwhee
Copy link
Collaborator

closing this as it was addressed in #576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gold2718 gold2718

Labels
capgen bugs, requests, etc. that involve ccpp_capgen enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use absolute paths for dependencies gold2718/ccpp-framework
4 participants
@gold2718 @climbfuji @mattldawson @peverwhee