-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in scripts/metadata2html.py #444
Comments
That's interesting, I thought I tested the script when I merged the updates/bug fixes for |
@dustinswales @ligiabernardet I had a look at this. Fixing the module imports and the call signature is easy, but the other problem is that the metadata_header |
@ligiabernardet @mzhangw @climbfuji |
Also, I don't see that RRTMGP is included in the "P8C primary physics enhancements" in NCAR/ccpp-physics#877 (comment) Dustin, the RRTMGP will definitely be part of p8c and, as such, of the p8 suite in CCPP. |
|
I have a PR in ccpp-framework that fixes metadata2html.py
… On Apr 4, 2022, at 8:49 AM, dustinswales ***@***.***> wrote:
@ligiabernardet <https://github.com/ligiabernardet> @mzhangw <https://github.com/mzhangw>
Also, I don't see that RRTMGP is included in the "P8C primary physics enhancements" in NCAR/ccpp-physics#877 (comment) <NCAR/ccpp-physics#877 (comment)>
—
Reply to this email directly, view it on GitHub <#444 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RJUVV24MTNNBDPUTGTVDL6PTANCNFSM5RIQQPDQ>.
You are receiving this because you were mentioned.
|
Description
In scripts/metadata2html.py, modules MetadataHeader is imported from metadata_table.py, but there is no MetadataHeader in metadata_table.py.
ccpp-framework/scripts/metadata2html.py
Line 12 in 8577ea3
An error occurs when referencing this module at L100:
ccpp-framework/scripts/metadata2html.py
Line 100 in 8577ea3
parse_metadata_file is in metadata_table.py, but not contained within MetadataHeader.
Possibly replace
from metadata_table import MetadataHeader
With
from metadata_table import parse_metadata_file
But the function parse_metadata_file has a different interface...
The text was updated successfully, but these errors were encountered: