Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Travis on all forks? #401

Closed
gold2718 opened this issue Aug 27, 2021 · 9 comments
Closed

Run Travis on all forks? #401

gold2718 opened this issue Aug 27, 2021 · 9 comments
Labels

Comments

@gold2718
Copy link
Collaborator

Currently, the Travis CI workflow is run in any fork on any push.
I feel this should be restricted to the main repo (NCAR/ccpp-framework), especially since git encourages frequent commits and currently a failure sends email to several (not involved for a fork push) parties.
@climbfuji, @JulieSchramm, Thoughts?

@climbfuji
Copy link
Collaborator

Fine by me. Julie, since you added those tests, do you want to change the CI tests so that they only run for NCAR/ccpp-framework?

@JulieSchramm
Copy link

I've hacked at this for a day without success, so maybe someone who is more familiar with Travis CI can take a look at it.

@climbfuji
Copy link
Collaborator

Is this still an issue? We are using github actions nowadays, and those run fine everywhere. I do recommend however to change

to

on:
  pull_request:
    paths-ignore:
      - 'doc/**'
      - '**.md'
      - '.github/ISSUE_TEMPLATE/*'
      - '.gitignore'

(or whatever the exact exclusion list should be)

@climbfuji
Copy link
Collaborator

@dustinswales
Copy link
Collaborator

@climbfuji I think we can close this
In #494 this is changed to trigger on PRs. Do we need to add paths-ignore?

@climbfuji
Copy link
Collaborator

paths-ignore just means that you don't run CI tests if you are only changing documentation (it still runs doxygen etc), README.md etc. Whatever you list there. Makes sense, or?

@dustinswales
Copy link
Collaborator

Gotcha. Then yes, lets add these exclusions to #494, and reference this Issue?

@climbfuji
Copy link
Collaborator

climbfuji commented Sep 14, 2023 via email

@climbfuji
Copy link
Collaborator

Closed via #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants