Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capgen must implement the unit conversion module (50 hours) #329

Closed
gold2718 opened this issue Oct 6, 2020 · 5 comments · Fixed by #504
Closed

capgen must implement the unit conversion module (50 hours) #329

gold2718 opened this issue Oct 6, 2020 · 5 comments · Fixed by #504
Assignees
@gold2718
Labels
capgen bugs, requests, etc. that involve ccpp_capgen capgen-unification enhancement
Milestone
capgen unification

Comments

@gold2718
Copy link
Collaborator

gold2718 commented Oct 6, 2020

capgen must implement automatic unit conversions.
The set of known unit conversions is already in conversion_tools/unit_conversion.py
@gold2718 gold2718 added enhancement capgen bugs, requests, etc. that involve ccpp_capgen labels Oct 6, 2020
@gold2718 gold2718 added this to the capgen unification milestone Oct 6, 2020
@gold2718 gold2718 self-assigned this Oct 6, 2020
@climbfuji climbfuji mentioned this issue Sep 30, 2021
Closed
@gold2718 gold2718 changed the title capgen must implement the unit conversion module capgen must implement the unit conversion module (50 hours) Oct 18, 2021
@gold2718
Copy link
Collaborator Author

The current design for this feature includes infrastructure for all known variable transforms (currently units, kind, and dimension ordering).

@gold2718 gold2718 mentioned this issue Oct 27, 2021
Merged
@gold2718 gold2718 mentioned this issue Jan 18, 2022
Closed
@climbfuji
Copy link
Collaborator

@gold2718 Both @dustinswales and myself started looking into enabling these var actions in the auto-generated code, but we were wondering if you have time to meet with us and share how you would have approached it. Clearly you must have had a path in mind when you coded up the various bits and pieces, but it's a little hard to follow for someone who didn't write the code ... and we want to get it right.

@gold2718
Copy link
Collaborator Author

gold2718 commented Oct 5, 2023

I would love to meet but would like to include @peverwhee who has been doing the majority of the capgen coding these days.
What sort of time do you think we can work out? I have a farily narrow band of times that overlap with your work day.
I can attend a meeting that ends by 10AM Boulder time or that is between11:30 and around 13:30. At the moment, I'm open at those times so let me know if the 3 of you find a common time that fits.

@climbfuji
Copy link
Collaborator

I would love to meet but would like to include @peverwhee who has been doing the majority of the capgen coding these days. What sort of time do you think we can work out? I have a farily narrow band of times that overlap with your work day. I can attend a meeting that ends by 10AM Boulder time or that is between11:30 and around 13:30. At the moment, I'm open at those times so let me know if the 3 of you find a common time that fits.

Thanks Steve, and yes, Courtney, Dustin and I talked just yesterday about meeting with you. Since I don't have your current email address, would you mind sending an email to me (my NOAA address still works) and I'll organize something. Thanks very much!

@dustinswales dustinswales mentioned this issue Oct 11, 2023
Merged
@climbfuji climbfuji linked a pull request Dec 28, 2023 that will close this issue
Add capability to do unit conversations to capgen #504
Merged
climbfuji added a commit that referenced this issue Jan 16, 2024
@dustinswales @grantfirl @climbfuji
Add capability to do unit conversations to capgen (#504)
800ea07 
This PR adds automatic conversions for supported unit and type transforms.
Also, included is a new ccpp variable property to indicate a scheme variables vertical orientation vertical, top_at_one.
As default, top_at_one is set to .false.(GFS ordering convention).
Adding top_at_one = .true. to a variable in a schemes metadata file will trigger automatic array flipping:

Addresses #329 and #403

Conversions supported:
https://github.com/NCAR/ccpp-framework/blob/main/scripts/conversion_tools/unit_conversion.py

---------

Co-authored-by: dustinswales <dswales@ucar.edu>
Co-authored-by: Grant Firl <grantf@ucar.edu>
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
@climbfuji
Copy link
Collaborator

Closed via #504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gold2718 gold2718

Labels
capgen bugs, requests, etc. that involve ccpp_capgen capgen-unification enhancement
Projects
capgen unification
Status: main (Done)
Milestone
capgen unification
Development

Successfully merging a pull request may close this issue.

Add capability to do unit conversations to capgen dustinswales/ccpp-framework
2 participants
@gold2718 @climbfuji