Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't compute log10(chl) for small chl #305

Open
wants to merge 1 commit into
base: dev/ncar
Choose a base branch
from
Open

Don't compute log10(chl) for small chl #305

wants to merge 1 commit into from

Commits on Sep 27, 2024

  1. Don't compute log10(chl) for small chl 

    if chl <= chl_min, we already have log10(chl_min) stored as a parameter.
Avoiding the computation of log10(chl) in those cases prevents the possibility
of a floating point exception, and lets us replace a max() statement with an if
check so it shouldn't affect performance.

This requires adding chl_min to the optics_type (which already has log10chl_min
and log10chl_max).
    @mnlevy1981
    mnlevy1981 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5726d94 View commit details
    Browse the repository at this point in the history