Remove an omp parallel do directive due to thread-unsafe cpu_clock #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/ncar #173 +/- ##
============================================
- Coverage 43.56% 43.46% -0.11%
============================================
Files 224 224
Lines 70511 71095 +584
============================================
+ Hits 30720 30903 +183
- Misses 39791 40192 +401
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an omp parallel do directive from MOM_set_diffusivity.F90. This is because the do-loop includes thread-unsafe cpu_clock_begin and cpu_clock_end calls. An alternative solution is to divide the outer j-loop into three parts and isolate the thread-unsafe calls, which would arguably degrade clarity, and (perhaps) non-omp performance.
Fixes: #161