Unify wrf/wrf-chem model_mod refactor #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on the latest 3d model_mod template * state variables added by namelist * removes wrf_static_data_for_data, uses state_stucture_mod Note for bitwise comparison with the existing wrf model_mod, using function interpolate_geometric_height #404 (comment)
2M variables forced to 2M qtys QTY_TEMPERATURE forced to QTY_POTENTIAL_TEMPERATURE
This is to avoid: ERROR FROM: source : state_structure_mod.f90 routine: get_varid_from_kind message: Found 2 > 1 message: ... for dart kind : QTY_SURFACE_PRESSURE However, should we use get_varid_from_varname instead
default is no bounds
for horizonatal bounds need to chose a qty on the same grid for static data
|
closing inactivity. Be aware of various copies of the wrf model mod may have some or all of the issues (see also https://github.com/NCAR/DART/issues?q=is%3Aissue+label%3Awrf+) depending on when the code was copied) Additionally, strongly recommend not copying the current wrf directory for new model mods. |
hkershaw-brown
changed the title
hkershaw-brown
changed the title
|
moving this to different directory to allow concurrent development on wrf and unified wrf model_mod. |
hkershaw-brown
added a commit
that referenced
this pull request
Sep 26, 2024
New model_mod directory so development can happen concurrently on wrf and wrf_unified. Original pull request #683
hkershaw-brown
added a commit
that referenced
this pull request
Sep 26, 2024
New model_mod directory so development can happen concurrently on wrf and wrf_unified. Original pull request #683
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactored WRF model mod for WRF & WRF CHEM.
Namelist selectable QTYS, see #404 for details.
Fixes issue
Fixes #404
Partial #359 (WRF)
Partial #624 (WRF)
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Bitwise tests during refactoring
Checklist for merging
Checklist for release
Testing Datasets