Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink footer section desktop & mobile #636

Merged
merged 9 commits into from
Sep 12, 2022
Merged

Conversation

HenrikeW
Copy link
Contributor

@HenrikeW HenrikeW commented Sep 8, 2022

Related issue(s) and PR(s)

This PR closes #588

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • the heading was removed
  • instead, the add-button has an explanatory text
  • the unsaved changes warning only takes space when it's actually displayed
  • the labels are slightly smaller
  • the issue label is shortened and combined with a placeholder that provides an example
  • some padding was removed
  • bootstrap classes were removed and replaced by flexboxes that better fit our needs
  • on mobile view / extreme zoom, the elements in the footer wrap below each other

Screenshot of the fix

image
image
image
image

Testing

  • try and play with the page:
    • in several screen sizes and zoom-levels
    • in different browsers
    • search for different things in different sizes
    • have some unsaved changes and combine with different screen sizes, browsers and search terms

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@HenrikeW HenrikeW requested a review from a team September 8, 2022 06:55
@KattisLej
Copy link
Contributor

Reviewing

Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, I have two comments about the label and the all changes saved....
Checked in different devices view and think it's working very well.

frontend/src/index.css Outdated Show resolved Hide resolved
frontend/src/pages/Report.tsx Show resolved Hide resolved
@jonandernovella
Copy link
Contributor

Looks good to me. The mobile UX when adding new rows is greatly improved with these changes.

@jonandernovella jonandernovella self-requested a review September 8, 2022 08:52
@HenrikeW HenrikeW requested a review from KattisLej September 12, 2022 06:39
Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job!

@KattisLej KattisLej merged commit 582137d into develop Sep 12, 2022
@KattisLej KattisLej deleted the fix/shrink-footer branch September 12, 2022 07:43
@jonandernovella jonandernovella mentioned this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shrink the bottom section
3 participants