Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time entry range calculations #627

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Add time entry range calculations #627

merged 1 commit into from
Sep 5, 2022

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #622

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  1. Updated visualization to show ranges
  2. Added functions to calculate time entry ranges

Screenshot of the fix

bild

Testing

  • Possibly the usual rebuild. It's rebased to current develop

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella
Add functions to get time entry ranges
8ccee6e 
The visualization is now also done using time ranges
@jonandernovella jonandernovella requested a review from a team September 5, 2022 13:59
@KattisLej
Copy link
Contributor

Starting review

KattisLej
KattisLej approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@KattisLej KattisLej merged commit 1cf19a4 into develop Sep 5, 2022
@KattisLej KattisLej deleted the dev/entry-ranges branch September 5, 2022 15:37
@jonandernovella jonandernovella mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KattisLej KattisLej KattisLej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calculate time entry ranges
2 participants
@jonandernovella @KattisLej