Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use current year for bar chart #604

Merged
1 commit merged into from
Aug 29, 2022
Merged

use current year for bar chart #604

1 commit merged into from
Aug 29, 2022

Conversation

HenrikeW
Copy link
Contributor

@HenrikeW HenrikeW commented Aug 29, 2022

Related issue(s) and PR(s)

This PR closes #594

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

instead of looking 12 months back from today to get the range for the time log overview, we set January 1st in the current year as a start date for the data fetch.

Screenshot of the fix

Testing

-go to the report page and check the API requests in the dev tools

  • The requests fetching time entries for a given time frame should have 2022-01-01 as start date and today's date as end date. It should look something like this:
    image

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@ghost ghost merged commit a472fea into develop Aug 29, 2022
@ghost ghost deleted the dev/bar-chart-time-frame branch August 29, 2022 14:08
@jonandernovella jonandernovella mentioned this pull request Sep 6, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

let horizontal bar show calendar year
1 participant